Skip to content

[14.0][FIX] l10n es aeat vat special prorrate purchase wrong tax amount when prorrate#710

Merged
eantones merged 2 commits into14.0from
14.0-fix-l10n_es_aeat_vat_special_prorrate_purchase-wrong_tax_amount_when_prorrate
Sep 19, 2025
Merged

[14.0][FIX] l10n es aeat vat special prorrate purchase wrong tax amount when prorrate#710
eantones merged 2 commits into14.0from
14.0-fix-l10n_es_aeat_vat_special_prorrate_purchase-wrong_tax_amount_when_prorrate

Conversation

@eantones
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings September 19, 2025 10:54
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes tax amount calculation issues in the Spanish AEAT VAT special prorate module for purchase orders. The fix addresses problems with context passing and dependency tracking that were causing incorrect tax calculations when prorate rules are applied.

  • Updates prorate_context functions to return tuple format instead of dictionary
  • Modifies tax computation to handle the new tuple-based context format
  • Adds missing dependencies for proper recomputation triggers

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
l10n_es_aeat_vat_special_prorrate_purchase/models/purchase_order.py Updates prorate context format and adds missing dependencies for purchase order calculations
l10n_es_aeat_vat_special_prorrate/models/account_tax.py Modifies tax factor computation to handle tuple-based prorate context and adds context dependency
l10n_es_aeat_vat_special_prorrate/models/account_move.py Updates prorate context function to return tuple format for consistency

Comment thread l10n_es_aeat_vat_special_prorrate/models/account_tax.py
@eantones eantones merged commit 9f346fc into 14.0 Sep 19, 2025
9 checks passed
@eantones eantones deleted the 14.0-fix-l10n_es_aeat_vat_special_prorrate_purchase-wrong_tax_amount_when_prorrate branch September 19, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants