Skip to content

[18.0][MIG] product_expiry_removal_required: Migration to 18.0#711

Open
deeniiz wants to merge 4 commits into18.0from
18.0-mig-product_expiry_removal_required
Open

[18.0][MIG] product_expiry_removal_required: Migration to 18.0#711
deeniiz wants to merge 4 commits into18.0from
18.0-mig-product_expiry_removal_required

Conversation

@deeniiz
Copy link
Copy Markdown
Collaborator

@deeniiz deeniiz commented Sep 19, 2025

No description provided.

Copilot AI review requested due to automatic review settings September 19, 2025 11:55
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the product_expiry_removal_required module from an earlier version to Odoo 18.0. The module makes the lot removal date mandatory when a product has expiry date functionality enabled.

  • Migration of module structure and files to 18.0 compatibility
  • Addition of validation logic to enforce removal date requirement
  • Updated documentation and metadata for the new version

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
__manifest__.py Module manifest with 18.0 version and dependencies
__init__.py Module initialization importing models
models/__init__.py Models package initialization
models/stock_lot.py Core logic with validation constraint for removal date
views/stock_lot_views.xml UI modification to make removal_date field required
README.rst Generated documentation file
readme/DESCRIPTION.md Module description content
readme/CONTRIBUTORS.md Contributors information
pyproject.toml Build configuration
static/description/index.html Generated HTML documentation

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 8, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale label Mar 8, 2026
@eantones eantones added no stale and removed stale labels Mar 8, 2026
@deeniiz deeniiz force-pushed the 18.0-mig-product_expiry_removal_required branch from 6a73967 to 780f729 Compare March 12, 2026 10:48
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (18.0@4b294fd). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...roduct_expiry_removal_required/models/stock_lot.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             18.0     #711   +/-   ##
=======================================
  Coverage        ?   72.72%           
=======================================
  Files           ?        3           
  Lines           ?       11           
  Branches        ?        2           
=======================================
  Hits            ?        8           
  Misses          ?        3           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants