Skip to content

[18.0][MIG] stock_picking_line_price: Migration to 18.0#714

Open
deeniiz wants to merge 5 commits into18.0from
18.0-mig-stock_picking_line_price
Open

[18.0][MIG] stock_picking_line_price: Migration to 18.0#714
deeniiz wants to merge 5 commits into18.0from
18.0-mig-stock_picking_line_price

Conversation

@deeniiz
Copy link
Copy Markdown
Collaborator

@deeniiz deeniiz commented Sep 22, 2025

No description provided.

Copilot AI review requested due to automatic review settings September 22, 2025 10:14
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the stock_picking_line_price module from a previous version to Odoo 18.0. The module adds price display functionality to stock picking lines.

Key changes:

  • Updates module version to 18.0.1.0.0 in the manifest
  • Adds view inheritance to display price_unit field in stock picking forms
  • Includes standard module structure with README and pyproject.toml

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

File Description
__manifest__.py Updates module metadata for 18.0 version with dependencies and data files
views/stock_picking_views.xml Adds view inheritance to display readonly price_unit field after product_id
pyproject.toml Adds build system configuration using whool
README.rst Provides module documentation with description and contributor information

<field name="priority" eval="20" />
<field name="arch" type="xml">
<xpath
expr="//notebook/page/field[@name='move_ids_without_package']/list/field[@name='product_id']"
Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The XPath expression is fragile and may break if the stock module's view structure changes. Consider using a more specific xpath that targets a unique element or use the field's explicit position in the tree structure.

Suggested change
expr="//notebook/page/field[@name='move_ids_without_package']/list/field[@name='product_id']"
expr="//field[@name='move_ids_without_package']//field[@name='product_id']"

Copilot uses AI. Check for mistakes.
@deeniiz deeniiz requested a review from eantones September 22, 2025 10:16
@deeniiz deeniiz force-pushed the 18.0-mig-stock_picking_line_price branch from 82c50e3 to 613d8c1 Compare September 22, 2025 13:14
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 8, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale label Mar 8, 2026
@eantones eantones added no stale and removed stale labels Mar 8, 2026
@deeniiz deeniiz force-pushed the 18.0-mig-stock_picking_line_price branch from 613d8c1 to e1bdfda Compare March 12, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants