Skip to content

[18.0][MIG] sale_order_cancel_stock: Migration to 18.0#717

Open
deeniiz wants to merge 5 commits into18.0from
18.0-mig-sale_order_cancel_stock
Open

[18.0][MIG] sale_order_cancel_stock: Migration to 18.0#717
deeniiz wants to merge 5 commits into18.0from
18.0-mig-sale_order_cancel_stock

Conversation

@deeniiz
Copy link
Copy Markdown
Collaborator

@deeniiz deeniiz commented Sep 22, 2025

No description provided.

Copilot AI review requested due to automatic review settings September 22, 2025 15:11
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the sale_order_cancel_stock module from an earlier version to Odoo 18.0. The module allows cancellation of sale orders with done stock moves only when the stock movements cancel each other out.

  • Complete module structure with models, manifest, and documentation
  • Implementation of stock picking and sale order cancellation logic
  • Standard OCA documentation and build files

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
__manifest__.py Module manifest defining dependencies and metadata for 18.0
__init__.py Module initialization importing models
models/__init__.py Models package initialization
models/sale_order.py Sale order model extension with cancellation logic
models/stock_picking.py Stock picking model extension with balance validation
README.rst Module documentation in reStructuredText format
readme/DESCRIPTION.md Brief module description
readme/CONTRIBUTORS.md List of module contributors
pyproject.toml Python build configuration
static/description/index.html Generated HTML documentation

Comment thread sale_order_cancel_stock/models/stock_picking.py
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 8, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale label Mar 8, 2026
@eantones eantones added no stale and removed stale labels Mar 8, 2026
@deeniiz deeniiz force-pushed the 18.0-mig-sale_order_cancel_stock branch from 1587ef4 to 1be1691 Compare March 12, 2026 11:14
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 21.15385% with 41 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (18.0@4b294fd). Learn more about missing BASE report.

Files with missing lines Patch % Lines
sale_order_cancel_stock/models/stock_picking.py 13.79% 25 Missing ⚠️
sale_order_cancel_stock/models/sale_order.py 20.00% 16 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             18.0     #717   +/-   ##
=======================================
  Coverage        ?   21.15%           
=======================================
  Files           ?        4           
  Lines           ?       52           
  Branches        ?       14           
=======================================
  Hits            ?       11           
  Misses          ?       41           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants