Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the contract_sii module from a previous version to Odoo 18.0, adding SII (Spanish tax system) integration capabilities to contracts. The module allows contracts to include SII registration keys and property information that propagates to generated invoices.
Key changes include:
- Complete module structure for SII contract functionality
- Model extension for contract.contract with SII fields and invoice preparation logic
- View form integration showing SII fields based on contract type and registration key
- Comprehensive test suite covering both sale and purchase contract scenarios
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
__manifest__.py |
Module manifest defining dependencies and metadata for 18.0 |
models/contract.py |
Core model extending contract.contract with SII fields and invoice preparation |
views/contract_view.xml |
Form view extension adding SII information group with conditional visibility |
tests/test_contract_sii.py |
Test suite verifying SII data propagation from contracts to invoices |
i18n/es.po |
Spanish translations for SII-related fields and interface elements |
README.rst |
Module documentation and contributor information |
__init__.py, models/__init__.py, tests/__init__.py, pyproject.toml |
Standard module structure files |
80872db to
0263eb7
Compare
0263eb7 to
75b9dd2
Compare
75b9dd2 to
870d042
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 18.0 #721 +/- ##
=======================================
Coverage ? 94.78%
=======================================
Files ? 5
Lines ? 115
Branches ? 8
=======================================
Hits ? 109
Misses ? 0
Partials ? 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.