Skip to content

[18.0][MIG] contract_sii: Migration to 18.0#721

Open
deeniiz wants to merge 6 commits into18.0from
18.0-mig-contract_sii
Open

[18.0][MIG] contract_sii: Migration to 18.0#721
deeniiz wants to merge 6 commits into18.0from
18.0-mig-contract_sii

Conversation

@deeniiz
Copy link
Copy Markdown
Collaborator

@deeniiz deeniiz commented Sep 25, 2025

No description provided.

Copilot AI review requested due to automatic review settings September 25, 2025 15:25
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the contract_sii module from a previous version to Odoo 18.0, adding SII (Spanish tax system) integration capabilities to contracts. The module allows contracts to include SII registration keys and property information that propagates to generated invoices.

Key changes include:

  • Complete module structure for SII contract functionality
  • Model extension for contract.contract with SII fields and invoice preparation logic
  • View form integration showing SII fields based on contract type and registration key
  • Comprehensive test suite covering both sale and purchase contract scenarios

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
__manifest__.py Module manifest defining dependencies and metadata for 18.0
models/contract.py Core model extending contract.contract with SII fields and invoice preparation
views/contract_view.xml Form view extension adding SII information group with conditional visibility
tests/test_contract_sii.py Test suite verifying SII data propagation from contracts to invoices
i18n/es.po Spanish translations for SII-related fields and interface elements
README.rst Module documentation and contributor information
__init__.py, models/__init__.py, tests/__init__.py, pyproject.toml Standard module structure files

Comment thread contract_sii/tests/test_contract_sii.py Outdated
@deeniiz deeniiz force-pushed the 18.0-mig-contract_sii branch from 75b9dd2 to 870d042 Compare March 12, 2026 11:40
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 94.78261% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (18.0@4b294fd). Learn more about missing BASE report.

Files with missing lines Patch % Lines
contract_sii/models/contract.py 83.78% 0 Missing and 6 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             18.0     #721   +/-   ##
=======================================
  Coverage        ?   94.78%           
=======================================
  Files           ?        5           
  Lines           ?      115           
  Branches        ?        8           
=======================================
  Hits            ?      109           
  Misses          ?        0           
  Partials        ?        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants