[18.0][MIG] contract_line_tax: Migration to 18.0#726
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the contract_line_tax module from a previous version to Odoo 18.0. The module adds tax functionality to contract lines and propagates those taxes to generated invoices.
Key changes:
- Complete module structure migration with models, views, tests, and documentation
- Implementation of tax handling in contract lines with fiscal position mapping
- Addition of comprehensive test coverage for tax propagation functionality
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
contract_line_tax/__manifest__.py |
Module manifest defining dependencies and metadata for 18.0 |
contract_line_tax/models/contract_line.py |
Core model extending contract.line with tax_ids field and invoice line preparation |
contract_line_tax/views/contract_view.xml |
XML views adding tax fields to contract forms and lists |
contract_line_tax/tests/test_contract_line.py |
Test cases verifying tax propagation from contract lines to invoices |
contract_line_tax/i18n/es.po |
Spanish translation file with outdated version reference |
| Other files | Supporting documentation, README files, and module structure files |
deeniiz
force-pushed
the
18.0-mig-contract_line_tax
branch
2 times, most recently
from
83798d6 to
7e1b18d
Compare
| > | ||
| <field | ||
| name="tax_ids" | ||
| domain="[('type_tax_use', '=', parent.contract_type),('company_id','=',parent.company_id)]" |
There was a problem hiding this comment.
Missing spaces around operators in domain expressions. Add spaces around '=' and ',' for better readability: [('type_tax_use', '=', parent.contract_type), ('company_id', '=', parent.company_id)]
| > | ||
| <field | ||
| name="tax_ids" | ||
| domain="[('type_tax_use', '=', parent.contract_type),('company_id','=',parent.company_id)]" |
There was a problem hiding this comment.
Missing spaces around operators in domain expressions. Add spaces around '=' and ',' for better readability: [('type_tax_use', '=', parent.contract_type), ('company_id', '=', parent.company_id)]
| <field | ||
| colspan="4" | ||
| name="tax_ids" | ||
| domain="[('type_tax_use', '=', parent.contract_type),('company_id','=',parent.company_id)]" |
There was a problem hiding this comment.
Missing spaces around operators in domain expressions. Add spaces around '=' and ',' for better readability: [('type_tax_use', '=', parent.contract_type), ('company_id', '=', parent.company_id)]
deeniiz
force-pushed
the
18.0-mig-contract_line_tax
branch
from
7e1b18d to
167b92a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 18.0 #726 +/- ##
=======================================
Coverage ? 92.68%
=======================================
Files ? 5
Lines ? 41
Branches ? 6
=======================================
Hits ? 38
Misses ? 1
Partials ? 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.