Skip to content

[18.0][MIG] product_unique_internal_reference: Migration to 18.0#733

Open
deeniiz wants to merge 11 commits into18.0from
18.0-mig-product_unique_internal_reference
Open

[18.0][MIG] product_unique_internal_reference: Migration to 18.0#733
deeniiz wants to merge 11 commits into18.0from
18.0-mig-product_unique_internal_reference

Conversation

@deeniiz
Copy link
Copy Markdown
Collaborator

@deeniiz deeniiz commented Oct 1, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 1, 2025 12:52
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the product_unique_internal_reference module from a previous version to Odoo 18.0. The module ensures unique internal references for products across companies and handles various scenarios including product templates, variants, and multi-company configurations.

Key Changes:

  • Migration of all module files to version 18.0
  • Updated manifest and version information
  • Comprehensive test suite covering duplicate reference scenarios
  • Multi-company aware validation logic

Reviewed Changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
__manifest__.py Updated version to 18.0.1.0.0 and module metadata
models/product_template.py Added validation constraints for unique internal references in templates
models/product_product.py Added validation constraints for unique internal references in product variants
tests/test_product_unique_internal_reference.py Comprehensive test suite covering all duplicate reference scenarios
hooks.py Pre-installation hook to check for existing conflicting references
i18n/es.po Spanish translation file for error messages and UI text
Various documentation files README, description, and contributor information

Comment thread product_unique_internal_reference/models/product_template.py Outdated
Comment thread product_unique_internal_reference/models/product_product.py Outdated
Comment thread product_unique_internal_reference/hooks.py Outdated
Comment thread product_unique_internal_reference/__manifest__.py Outdated
"Exception"
msgstr ""
"Las referencias internas no son iguales, esto no debería haber lanzado una "
"excepción"
Copy link

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .po file is missing a blank line at the end of the file, which is required by coding guidelines.

Copilot uses AI. Check for mistakes.
@deeniiz deeniiz force-pushed the 18.0-mig-product_unique_internal_reference branch from 496cfcc to 77ff40c Compare October 1, 2025 12:56
@deeniiz deeniiz requested a review from eantones October 1, 2025 12:56
@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale label Mar 15, 2026
@eantones eantones added no stale and removed stale labels Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants