Skip to content

[18.0][MIG] account_asset_management_extension: Migration to 18.0#754

Open
deeniiz wants to merge 10 commits into18.0from
18.0-mig-account_asset_management_extension
Open

[18.0][MIG] account_asset_management_extension: Migration to 18.0#754
deeniiz wants to merge 10 commits into18.0from
18.0-mig-account_asset_management_extension

Conversation

@deeniiz
Copy link
Copy Markdown
Collaborator

@deeniiz deeniiz commented Oct 9, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 9, 2025 15:56
@deeniiz deeniiz changed the title [18.0]account_asset_management_extension [18.0][MIG] account_asset_management_extension: Migration to 18.0 Oct 9, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new Odoo module called account_asset_management_extension for version 18.0 that extends the base account asset management functionality with additional fields and features.

  • Adds new fields to account assets including invoice reference, invoice date, quantity, tax base amount, and tax information
  • Implements validation logic to ensure consistency between asset data and related invoice line data
  • Provides a new user interface tab "Other Information" to display the extended asset fields

Reviewed Changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
__manifest__.py Module manifest defining dependencies and basic metadata
__init__.py Module initialization importing models
models/__init__.py Models package initialization
models/account_asset.py Core asset model extension with new fields and validation logic
models/account_move.py Account move model extension for asset value preparation
views/account_asset.xml UI view extending asset form with "Other Information" tab
i18n/es.po Spanish translations for the module
readme/ Documentation files including description and contributors
static/description/index.html Generated HTML documentation
pyproject.toml Build system configuration
README.rst Main documentation file

#: code:addons/account_asset_management_extension/models/account_asset.py:0
#, python-format
msgid "Quantity must be the same as the one in the invoice line: %s"
msgstr "La cantidad debe ser la misma que la establecida en la línea de factura: %s"
Copy link

Copilot AI Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .po file is missing a blank line at the end of the file as required by coding guidelines.

Copilot generated this review using guidance from repository custom instructions.

{
"name": "Account Asset Management Extension",
"summary": "This module adds additional fields in assets",
Copy link

Copilot AI Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The summary in the manifest should be consistent with the description in readme/DESCRIPTION.md. The readme says 'This module adds additional fields on assets' but the manifest says 'in assets'.

Copilot generated this review using guidance from repository custom instructions.
@deeniiz deeniiz force-pushed the 18.0-mig-account_asset_management_extension branch from 5f31907 to df77797 Compare March 18, 2026 09:42
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 46.15385% with 42 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (18.0@4b294fd). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...asset_management_extension/models/account_asset.py 41.79% 39 Missing ⚠️
..._asset_management_extension/models/account_move.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             18.0     #754   +/-   ##
=======================================
  Coverage        ?   46.15%           
=======================================
  Files           ?        4           
  Lines           ?       78           
  Branches        ?       20           
=======================================
  Hits            ?       36           
  Misses          ?       42           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants