[18.0][MIG] account_asset_transfer_extension: Migration to 18.0#763
Open
[18.0][MIG] account_asset_transfer_extension: Migration to 18.0#763
Conversation
…onstrains throws warnings
…ted journal items linked to transferred assets
deeniiz
force-pushed
the
18.0-mig-account_asset_transfer_extension
branch
from
a0a5218 to
cf7d0d8
Compare
…fer moves When a user clicks "unpost" on the init_entry depreciation line of a to_asset, the unlink_move() method deletes the linked move. Since the init_entry points to the CURS transfer move, this causes the transfer move to be permanently deleted. The from_assets lose their transfer_move_id (set to NULL by ondelete), and the revert wizard shows "Nothing to revert" because it can no longer find the to_assets. Add an override of unlink_move() on account.asset.line that checks whether the move being deleted is referenced as transfer_move_id by any asset. If so, raise a UserError directing the user to use the "Revert Transfer" action instead.
Add complete ca.po translation for all existing module strings.
Add readme/DESCRIPTION.rst and readme/CONTRIBUTORS.rst with module description and contributor list. Regenerate README.rst.
deeniiz
force-pushed
the
18.0-mig-account_asset_transfer_extension
branch
from
03f8fbc to
247bfa5
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 18.0 #763 +/- ##
=======================================
Coverage ? 34.17%
=======================================
Files ? 8
Lines ? 158
Branches ? 34
=======================================
Hits ? 54
Misses ? 104
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.