[18.0][MIG] account_invoice_same_accounting_date: Migration to 18.0#854
Open
[18.0][MIG] account_invoice_same_accounting_date: Migration to 18.0#854
Conversation
…counting date the same as the invoice date by default
deeniiz
force-pushed
the
18.0-mig-account_invoice_same_accounting_date
branch
from
8757437 to
c623321
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 18.0 #854 +/- ##
=======================================
Coverage ? 53.84%
=======================================
Files ? 3
Lines ? 13
Branches ? 2
=======================================
Hits ? 7
Misses ? 6
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…date Override _get_accounting_date instead of adding a separate onchange handler. For purchase documents, route through super's sale document branch (via a scoped context flag on is_sale_document) which applies the tax lock date check and returns invoice_date directly, without the max(invoice_date, today) logic that prevents proper currency recomputation. This lets the core _onchange_invoice_date detect the date change and call _onchange_currency, which recomputes all line debit/credit at the correct exchange rate. The previous _onchange_invoice_date_accounting set date = invoice_date without triggering line recomputations, causing base and tax lines to use different exchange rates on multi-currency invoices.
deeniiz
force-pushed
the
18.0-mig-account_invoice_same_accounting_date
branch
from
c623321 to
112fbfd
Compare
deeniiz
force-pushed
the
18.0-mig-account_invoice_same_accounting_date
branch
from
112fbfd to
b3f4775
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.