Conversation
…e_rental_extension sale_rental_extension referenced rental_base XML IDs (views, menus, rental_sale_type) and sale_order_type fields (type_id) without declaring rental_base as a dependency. Instead of adding coupling, move all rental_base-dependent code to rental_base_extension where it belongs. Moved from sale_rental_extension: - SaleOrder model (rental status tracking, is_rental_order, picking helpers) - StockPicking model (is_rental_picking, sign-to-validate) - ResCompany and ResConfigSettings (signature terms) - Dedicated rental form/tree/kanban/calendar/search views and actions - Rental app menus and rental_base view deactivations - Config settings view, stock picking view, delivery slip report - JS signature widget, SCSS kanban styles, XML signature dialog - Rental status tests All XML IDs, view names, file names and internal identifiers follow OCA naming conventions (sale_order_view_form_rental, sale_order_action_rental, sale_order_menu_rental, etc.).
Code that referenced rental_base (views, menus, actions, SaleOrder model, StockPicking model, config settings, signature widget, delivery report and tests) has been moved to rental_base_extension where it belongs. This module now only extends sale_rental with: - SaleOrderLine: rental_qty defaults, inline editing, qty sync - sale.rental: kanban, calendar views and search enhancements
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 16.0 #866 +/- ##
==========================================
+ Coverage 44.27% 44.30% +0.02%
==========================================
Files 310 313 +3
Lines 6227 6230 +3
Branches 989 989
==========================================
+ Hits 2757 2760 +3
Misses 3449 3449
Partials 21 21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sale_rental_extensionreferencedrental_baseXML IDs andtype_idfromsale_order_typewithout declaringrental_baseas a dependency, causing installation errors whenrental_basewas not installedrental_base-dependent code torental_base_extensionwhere it naturally belongsrental_base_extension→rental_base,sale_rental_extension→sale_rentalTest plan
sale_rental_extension, updaterental_base_extension, reinstallsale_rental_extensionsale_rental_extensionalone (withoutrental_base) on a clean DB — should not crash