[14.0][IMP] connector_extension: add server_tz field to backend#884
Merged
[14.0][IMP] connector_extension: add server_tz field to backend#884
Conversation
b5eb9dd to
b6f169d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 14.0 #884 +/- ##
==========================================
+ Coverage 50.71% 50.75% +0.04%
==========================================
Files 979 979
Lines 16752 16756 +4
Branches 3566 3567 +1
==========================================
+ Hits 8495 8505 +10
+ Misses 8039 8034 -5
+ Partials 218 217 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
External systems may have a server timezone different from the data timezone. For example, a Portuguese healthcare system (data TZ) hosted on a Spanish server (server TZ). Technical timestamps like modification dates follow the server TZ, while business data follows the data TZ. Add a mandatory server_tz field and server_tz_to_utc/utc_to_server_tz methods. Extract _convert_tz static helper to avoid code duplication across all conversion methods. Rename tz_to_local to utc_to_local for clarity, keeping tz_to_local as a deprecated alias.
b6f169d to
87efe13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server_tzfield toconnector.extension.backendfor backends where the server timezone differs from the data timezoneserver_tz_to_utcandserver_tz_to_localconversion methods with fallback totzwhen not setTest plan
server_tzset (fallback totz)server_tzon a backend and verifyserver_tz_to_local/server_tz_to_utcuse the correct timezone