Skip to content

[14.0][FIX] delivery_mrw_no_info: handle None response in tracking states#887

Merged
eantones merged 1 commit into14.0from
14.0-fix-delivery_mrw_info-tracking_states
May 1, 2026
Merged

[14.0][FIX] delivery_mrw_no_info: handle None response in tracking states#887
eantones merged 1 commit into14.0from
14.0-fix-delivery_mrw_info-tracking_states

Conversation

@deeniiz
Copy link
Copy Markdown
Collaborator

@deeniiz deeniiz commented Apr 9, 2026

No description provided.

@deeniiz deeniiz requested review from Copilot and eantones and removed request for Copilot April 9, 2026 15:58
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens the delivery_mrw_no_info override of MRW tracking-state retrieval so it can tolerate None responses from the upstream MRW request layer.

Changes:

  • Add a fallback response structure when _original_get_tracking_states() returns None or has a None "Seguimiento" payload.
  • Ensure "MensajeSeguimiento" is set to the expected “Busqueda correcta por Número de Albarán.” value and inject a synthetic “no info” tracking state.

Comment thread delivery_mrw_no_info/models/mrw_request.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.37%. Comparing base (ba6ec84) to head (5a16895).
⚠️ Report is 5 commits behind head on 14.0.

Files with missing lines Patch % Lines
delivery_mrw_no_info/models/mrw_request.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             14.0     #887      +/-   ##
==========================================
- Coverage   50.37%   50.37%   -0.01%     
==========================================
  Files        1174     1174              
  Lines       20087    20089       +2     
  Branches     4267     4268       +1     
==========================================
  Hits        10119    10119              
- Misses       9734     9736       +2     
  Partials      234      234              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@deeniiz deeniiz changed the title [FIX] delivery_mrw_no_info: handle None response in tracking states [14.0][FIX] delivery_mrw_no_info: handle None response in tracking states Apr 13, 2026
@deeniiz deeniiz force-pushed the 14.0-fix-delivery_mrw_info-tracking_states branch from eec3a2b to 456ae02 Compare April 16, 2026 09:33
@deeniiz deeniiz force-pushed the 14.0-fix-delivery_mrw_info-tracking_states branch from 456ae02 to 5a16895 Compare April 16, 2026 09:35
@eantones eantones merged commit a65d4f1 into 14.0 May 1, 2026
11 of 13 checks passed
@eantones eantones deleted the 14.0-fix-delivery_mrw_info-tracking_states branch May 1, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants