[18.0][FIX+IMP] connector_extension: post-migration fixes and improvements#891
Open
[18.0][FIX+IMP] connector_extension: post-migration fixes and improvements#891
Conversation
In Odoo 18, queue_job forbids commits during job execution via _prevent_commit to avoid releasing the job lock prematurely. The cr.commit() in bind_export was an optimization for concurrent binding creation that is no longer compatible. The _retry_unique_violation context manager still handles race conditions via PostgreSQL's UNIQUE constraint without needing an explicit commit.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 18.0 #891 +/- ##
==========================================
+ Coverage 29.76% 29.80% +0.03%
==========================================
Files 17 17
Lines 1233 1228 -5
Branches 252 251 -1
==========================================
- Hits 367 366 -1
+ Misses 866 862 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.