[16.0][BP][IMP] connector_extension: remove cr.commit() from bind_export#893
[16.0][BP][IMP] connector_extension: remove cr.commit() from bind_export#893
Conversation
…s and added docstrings
In Odoo 18, queue_job forbids commits during job execution via _prevent_commit to avoid releasing the job lock prematurely. The cr.commit() in bind_export was an optimization for concurrent binding creation that is no longer compatible. The _retry_unique_violation context manager still handles race conditions via PostgreSQL's UNIQUE constraint without needing an explicit commit.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 16.0 #893 +/- ##
=======================================
Coverage 44.28% 44.28%
=======================================
Files 317 317
Lines 6294 6294
Branches 1000 999 -1
=======================================
Hits 2787 2787
Misses 3486 3486
Partials 21 21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Superseded by #895. This PR's approach (removing Replaced by #895, which keeps the eager |
No description provided.