Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 1, 2025

Addresses review feedback on ADR-004 noting that OAuth2 request code blocks use illustrative multi-line formatting that differs from actual URL-encoded requests.

Changes

  • Added clarifying text to both OAuth2 example code blocks indicating they are "formatted for readability; actual requests are URL-encoded"
    • OAuth2 Client Credentials example (line 102)
    • OAuth 2.0 Token Exchange example (line 161)

Before:

Example token exchange request:

After:

Example token exchange request (formatted for readability; actual requests are URL-encoded):

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: reinkrul <1481228+reinkrul@users.noreply.github.com>
Copilot AI changed the title [WIP] Update ADR-004 to address feedback on authentication API Clarify OAuth2 code examples are formatted for readability Dec 1, 2025
Copilot AI requested a review from reinkrul December 1, 2025 12:50
@reinkrul reinkrul closed this Dec 1, 2025
@reinkrul reinkrul deleted the copilot/sub-pr-251 branch December 1, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants