feat(nutsnode): propagate tracing config to embedded nuts-node #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass tracing configuration (OTLP endpoint, insecure flag) from knooppunt to the embedded nuts-node via environment variables. Add otelhttp transport to the reverse proxy for proper trace context propagation across the proxy boundary. Depends on nuts-foundation/nuts-node#3946
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables distributed tracing across the proxy boundary between knooppunt and the embedded nuts-node by propagating the OTLP tracing configuration and instrumenting the reverse proxy with OpenTelemetry.
- Adds
otelhttp.NewTransportto the reverse proxy for automatic span creation on outgoing requests - Propagates tracing configuration (OTLP endpoint and insecure flag) from knooppunt to nuts-node via environment variables
- Updates proxy comments to clarify trace context propagation behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| component/nutsnode/proxy.go | Adds otelhttp transport to reverse proxy and updates comments explaining trace context propagation |
| component/nutsnode/component.go | Introduces TracingConfig struct and logic to pass tracing configuration to nuts-node via environment variables |
| cmd/start.go | Passes tracing config from knooppunt's main config to nuts-node component |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
reinkrul
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass tracing configuration (OTLP endpoint, insecure flag) from knooppunt to the embedded nuts-node via environment variables. Add otelhttp transport to the reverse proxy for proper trace context propagation across the proxy boundary:
Depends on nuts-foundation/nuts-node#3946