Skip to content

Conversation

@dmeijboom
Copy link
Contributor

This PR adds an extraEnv Helm value which can be used to set arbitrary environment values on the nuts-node deployment. This is often used when values need to be injected dynamically. My use-case is setting the NUTS_STORAGE_SQL_CONNECTION environment variable automatically from an automatically generated secret (required for: nuts-foundation/nuts-knooppunt#111).

Although it's not part of the default Helm chart starter template it's a common property that is available in many other Helm charts.

@qltysh
Copy link

qltysh bot commented Sep 7, 2025

Diff Coverage: Not applicable. There was no coverage data reported for the files in this diff.

Total Coverage: This PR will increase coverage by 0.02%.

File Coverage Changes
Path File Coverage Δ Indirect
github.com/nuts-foundation/nuts-node/network/dag/consistency.go 2.4
github.com/nuts-foundation/nuts-node/network/transport/grpc/connection.go 3.7
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Contributor

@rolandgroen rolandgroen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change, looks good.

@rolandgroen
Copy link
Contributor

@reinkrul can you approve this PR?

Copy link
Member

@gerardsn gerardsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

impersonating @reinkrul

@gerardsn gerardsn merged commit d62b658 into nuts-foundation:master Oct 28, 2025
9 checks passed
@dmeijboom dmeijboom deleted the feat/add-extraenv-to-helm-chart-values branch October 30, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants