Skip to content

Conversation

@nollidnosnhoj
Copy link
Contributor

This allows the user using the helm to add selector labels to the nuts-node deployment, alongside using the standard selector labels.

For example, in order to use workload identity on an Azure Kubernetes Service (AKS) cluster, you need to add a specific selector label to the deployment manifest.

@qltysh
Copy link

qltysh bot commented Oct 30, 2025

Diff Coverage: Not applicable. There was no coverage data reported for the files in this diff.

Total Coverage: This PR will increase coverage by 0.02%.

File Coverage Changes
Path File Coverage Δ Indirect
auth/services/irma/factory.go 7.8
network/dag/consistency.go -2.4
network/dag/notifier.go 0.7
network/transport/grpc/connection_list.go 1.1
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@reinkrul
Copy link
Member

@rolandgroen can you review this?

@rolandgroen rolandgroen self-requested a review October 31, 2025 10:05
Copy link
Contributor

@rolandgroen rolandgroen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweak. Approved.

@nollidnosnhoj nollidnosnhoj force-pushed the feat/add-podlabels-to-helm-chart branch from f93e85d to 594db95 Compare October 31, 2025 11:00
@reinkrul
Copy link
Member

@nollidnosnhoj this repo requires commits to be signed

@nollidnosnhoj
Copy link
Contributor Author

@reinkrul hi. the commit should be signed now.

@gerardsn
Copy link
Member

Learning from #3934, should the chart version be updated?

@nollidnosnhoj
Copy link
Contributor Author

@gerardsn I could update the chart version in this pull request, but I figured the maintainer(s) would update the chart.yaml to the appropriate version number.

@gerardsn
Copy link
Member

gerardsn commented Nov 3, 2025

@gerardsn I could update the chart version in this pull request, but I figured the maintainer(s) would update the chart.yaml to the appropriate version number.

@rolandgroen @reinkrul

@reinkrul
Copy link
Member

@nollidnosnhoj can you update the chart version to 0.0.7?

@reinkrul
Copy link
Member

Thanks!

@reinkrul reinkrul merged commit 6a3a562 into nuts-foundation:master Nov 11, 2025
9 checks passed
@nollidnosnhoj nollidnosnhoj deleted the feat/add-podlabels-to-helm-chart branch November 11, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants