-
Notifications
You must be signed in to change notification settings - Fork 20
feat: add pod labels to helm chart values. #3935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pod labels to helm chart values. #3935
Conversation
|
Diff Coverage: Not applicable. There was no coverage data reported for the files in this diff. Total Coverage: This PR will increase coverage by 0.02%. File Coverage Changes
🛟 Help
|
|
@rolandgroen can you review this? |
rolandgroen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor tweak. Approved.
f93e85d to
594db95
Compare
|
@nollidnosnhoj this repo requires commits to be signed |
|
@reinkrul hi. the commit should be signed now. |
|
Learning from #3934, should the chart version be updated? |
|
@gerardsn I could update the chart version in this pull request, but I figured the maintainer(s) would update the chart.yaml to the appropriate version number. |
|
|
@nollidnosnhoj can you update the chart version to |
|
Thanks! |
This allows the user using the helm to add selector labels to the nuts-node deployment, alongside using the standard selector labels.
For example, in order to use workload identity on an Azure Kubernetes Service (AKS) cluster, you need to add a specific selector label to the deployment manifest.