Skip to content

chore: fix some comments #3945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rifeplight wants to merge 1 commit into from
Closed

chore: fix some comments #3945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion http/tokenV2/authorized_keys_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (
"github.com/stretchr/testify/require"
)

// testEmptyAuthorizedKeys ensures an empty authorized_keys file is properly parsed
// TestEmptyAuthorizedKeys ensures an empty authorized_keys file is properly parsed
func TestEmptyAuthorizedKeys(t *testing.T) {
keys, err := parseAuthorizedKeys([]byte(""))
assert.Empty(t, keys)
Expand Down
2 changes: 1 addition & 1 deletion http/tokenV2/middleware_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,7 @@ func TestValidJWTECDSAES384(t *testing.T) {
assert.NoError(t, err)
}

// TestValidJWTECDSAES384 ensures a valid JWT signed by an ECDSA 384-bit key authorizes a request
// TestValidJWTECDSAES512 ensures a valid JWT signed by an ECDSA 512-bit key authorizes a request
func TestValidJWTECDSAES512(t *testing.T) {
// Generate a new test key and jwt serializer
_, serializer, authorizedKey := generateECDSATestKey(t, elliptic.P521(), jwa.ES512)
Expand Down
2 changes: 1 addition & 1 deletion pki/validator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ func (v *validator) getCert(subject string) (*x509.Certificate, bool) {
return issuer.(*x509.Certificate), true
}

// addEndpoint adds the CRL endpoint if it does not exist. Returns an error if the CRL issuer does not match the expected issuer.
// addEndpoints adds the CRL endpoint if it does not exist. Returns an error if the CRL issuer does not match the expected issuer.
func (v *validator) addEndpoints(certIssuer *x509.Certificate, endpoints []string) error {
for _, endpoint := range endpoints {
if crl, ok := v.getCRL(endpoint); ok {
Expand Down
Loading