Skip to content

Conversation

sandros94
Copy link
Contributor

Mostly for testing but also useful for those interested in, especially now that we are close to a stable v4 release.

Will happily contribute and help with the migration

Might as well keep this in draft and only merge once UI v4 stable gets release, @larbish WDYT?

Copy link

vercel bot commented Sep 4, 2025

@sandros94 is attempting to deploy a commit to the NuxtLabs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codesandbox bot commented Sep 4, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

pkg-pr-new bot commented Sep 4, 2025

Open in StackBlitz

npm i https://pkg.pr.new/create-docus@1173
npm i https://pkg.pr.new/docus@1173

commit: 23d88e3

@sandros94
Copy link
Contributor Author

sandros94 commented Sep 4, 2025

pkg.pr.new might being having problems, as various things (like the useDocusI18n composable) are broken 🤔

EDIT: it seems that the issue is caused by unimport, @benjamincanac provided some guidance like this one https://github.com/nuxt-ui-templates/starter/blob/ad77c4a5fa3f7f0a9d39a32948ba49b7a8a0f415/package.json#L27

Tho I'm still having some typography issues, but same applies to Docus with UI Pro v3

Copy link
Collaborator

@larbish Could you try this reproduction https://github.com/JAMflow-Cloud/dev-docs? The typography is broken 🤔

@sandros94
Copy link
Contributor Author

@larbish Could you try this reproduction https://github.com/JAMflow-Cloud/dev-docs? The typography is broken 🤔

Found the issue: https://github.com/nuxtlabs/docus/blob/79290cb2bf14a4fe656dd5e3cbed7e1d5e572847/layer/app/templates/landing.vue#L45

IMO we should fix this in a different way than nuxt/content#3419

@larbish
Copy link
Collaborator

larbish commented Sep 10, 2025

Prose issue have been fixed in #1176, is there any other blocking point I can help on @sandros94? Official v4 release should be landing soon 🚀

@sandros94
Copy link
Contributor Author

Prose issue have been fixed in #1176, is there any other blocking point I can help on @sandros94? Official v4 release should be landing soon 🚀

Ah yes! If you could update the french translation, as I did fix a few things but definitely not all 🙏

@atinux
Copy link
Contributor

atinux commented Sep 11, 2025

Thanks you @sandros94 ❤️

Copy link

vercel bot commented Sep 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
docus Ready Ready Preview Sep 12, 2025 8:31am

@sandros94
Copy link
Contributor Author

Did push some more fixes, doing a quick regex search (pro(?:(?!\w)|[_-])) in the repo finds a few UI Pro mentions left within the french translation, don't really like to touch them via LLMs and would love to ask you to fix those, if possible.

Personally speaking I would say it is ready for merge, we could either wait for stable release or publish a first pre-release with UI v4 alpha (that is more than usable IMO)

@sandros94 sandros94 marked this pull request as ready for review September 12, 2025 07:32
@larbish
Copy link
Collaborator

larbish commented Sep 12, 2025

Great! Thanks again @sandros94, indeed I'm already using the alpha pkg that works well. I'll take care of the french translations. Let’s wait for the official release, it should arrive next week. As soon as it’s out, we’re good to go!

@larbish
Copy link
Collaborator

larbish commented Sep 12, 2025

Just updated fr translations and authorize deployment to have a check at the preview.

@sandros94
Copy link
Contributor Author

The latest updates on your projects. Learn more about Vercel for GitHub.
Project Deployment Preview Updated (UTC)
docus Ready Ready Preview Sep 12, 2025 8:31am

there's no public preview for vercel's PR deployments?

@larbish
Copy link
Collaborator

larbish commented Sep 12, 2025

@sandros94
Copy link
Contributor Author

@sandros94 Here is a public link: https://docus-git-fork-sandros94-ui-v4-alpha-nuxtlabs.vercel.app/en

Still requires me to ask for permission 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants