-
Notifications
You must be signed in to change notification settings - Fork 182
chore: use Nuxt UI v4 alpha #1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@sandros94 is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
commit: |
EDIT: it seems that the issue is caused by Tho I'm still having some typography issues, but same applies to Docus with UI Pro v3 |
@larbish Could you try this reproduction https://github.com/JAMflow-Cloud/dev-docs? The typography is broken 🤔 |
Found the issue: https://github.com/nuxtlabs/docus/blob/79290cb2bf14a4fe656dd5e3cbed7e1d5e572847/layer/app/templates/landing.vue#L45 IMO we should fix this in a different way than nuxt/content#3419 |
Prose issue have been fixed in #1176, is there any other blocking point I can help on @sandros94? Official v4 release should be landing soon 🚀 |
Ah yes! If you could update the french translation, as I did fix a few things but definitely not all 🙏 |
Thanks you @sandros94 ❤️ |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Did push some more fixes, doing a quick regex search ( Personally speaking I would say it is ready for merge, we could either wait for stable release or publish a first pre-release with UI v4 alpha (that is more than usable IMO) |
Great! Thanks again @sandros94, indeed I'm already using the alpha pkg that works well. I'll take care of the french translations. Let’s wait for the official release, it should arrive next week. As soon as it’s out, we’re good to go! |
Just updated fr translations and authorize deployment to have a check at the preview. |
there's no public preview for vercel's PR deployments? |
@sandros94 Here is a public link: https://docus-git-fork-sandros94-ui-v4-alpha-nuxtlabs.vercel.app/en |
Still requires me to ask for permission 🤔 |
Mostly for testing but also useful for those interested in, especially now that we are close to a stable v4 release.
Will happily contribute and help with the migration
Might as well keep this in draft and only merge once UI v4 stable gets release, @larbish WDYT?