Modularize dependency configuration#4
Merged
bryevdv merged 9 commits intonv-legate:mainfrom May 2, 2025
bryevdv:bv/modularize
Merged
Modularize dependency configuration#4bryevdv merged 9 commits intonv-legate:mainfrom bryevdv:bv/modularize
bryevdv merged 9 commits intonv-legate:mainfrom
bryevdv:bv/modularize
Conversation
Jacobfaib
reviewed
May 2, 2025
Contributor
Author
|
Huh @Jacobfaib any idea why this would fail only on 3.10? Alternatively, do we need to support 3.10? |
Contributor
Author
|
I guess there were some changes to enums (and their formatting) starting in 3.11. Fixed with an explicit |
Jacobfaib
approved these changes
May 2, 2025
Contributor
Author
|
Not sure why Edit: doh, because there is a second workflow file.... fixed in 1739d09 pushed directly to main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modularizes the handling of package dependencies. Package name and dependencies are now specified declaratively as class vars:
All transitive dependencies of the main package are automatically collected. Dependency package instances are still available via the
depsnamespace on packages, e.g.self.deps.CUDAfor theLegionpackage above.All package definitions except
CMakeandPythonwere removed. Once this is merged and tagged 1.2.0 a separate PR will updatelegate.internalto use define and use them locally from there.This PR also enables running of unit tests in CI.