- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 633
feat: Allow to expand until certain condition is met #2790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
    
  
     Closed
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            16 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      cd96cf9
              
                Add new parameter to expand function
              
              
                ghostbuster91 9f0a224
              
                feat: Add more controll to expand-all function
              
              
                ghostbuster91 f691687
              
                Working better
              
              
                ghostbuster91 7cf4cf8
              
                Remove print statements
              
              
                ghostbuster91 e8c4ce4
              
                Pass function to populate_node to userland
              
              
                ghostbuster91 4510332
              
                format code
              
              
                ghostbuster91 a3f1588
              
                Call populate_node in case it wasn't called by the user
              
              
                ghostbuster91 e0e12a4
              
                Ignore unused variable
              
              
                ghostbuster91 96ffae1
              
                Remove iterator from should_expand
              
              
                ghostbuster91 7bda685
              
                Cleanup code from redundant stuff
              
              
                ghostbuster91 06aad16
              
                Add documentation
              
              
                ghostbuster91 57af3c4
              
                Try to minimize the changes
              
              
                ghostbuster91 38d9e07
              
                Minimize amount of changes further
              
              
                ghostbuster91 b506e05
              
                Remove redundant condition
              
              
                ghostbuster91 b67209a
              
                luals types for expand_until, rename variable for consistency
              
              
                alex-courtis 3c093d4
              
                doc format and example clarification
              
              
                alex-courtis File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: guarding against calling this function with a file node