Skip to content

fix(#2794): sshfs compatibility #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 9, 2024
Merged

fix(#2794): sshfs compatibility #2893

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
569e6a2
add type fallback for nil types
mxple Sep 1, 2024
d95891c
add PR suggestions
mxple Sep 2, 2024
2e49425
Update lua/nvim-tree/explorer/explore.lua
mxple Sep 6, 2024
d45a16b
use type from fs_stat for sshfs compatibility
mxple Sep 8, 2024
0d322ae
Merge branch 'master' into fix_sshfs_compatibility
alex-courtis Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lua/nvim-tree/explorer/explore.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ local function populate_children(handle, cwd, node, git_status, parent)
end

local abs = utils.path_join { cwd, name }
t = t or (vim.loop.fs_stat(abs) or {}).type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an extra (not expensive as usually short circuited) call to fs_stat.

Could we put this after line 44?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved after line 44, please review.


if Watcher.is_fs_event_capable(abs) then
local profile = log.profile_start("explore populate_children %s", abs)
Expand Down