Fix first vkCmdPipelineBarrier in buildTlas's command buffer
#81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Argument `srcStageMask` in `vkCmdPipelineBarrier` should be set to `VK_PIPELINE_STAGE_TRANSFER_BIT` in order to guarantee synchronization of `vkCmdCopyBuffer`. Signed-off-by: Kacper Zielinski <kacper.zielinski@intel.com>
KacperZielinski-Intel
force-pushed
the
fix/buildTlas
branch
from
2b7a298 to
f9e419b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified structure of faulty command buffer:
vkCmdPipelineBarrieris set to synchronizeVK_PIPELINE_STAGE_ACCELERATION_STRUCTURE_BUILD_BIT_KHRoperations, both before and after this barrier (srcStageMaskanddstStageMask).However, Vulkan specification states that
vkCmdCopyBufferis executed in pipeline stage covered byVK_PIPELINE_STAGE_TRANSFER_BIT,which means that this
vkCmdPipelineBarrieris not guaranteed to synchronize avkCmdCopyBufferoperation,as
srcStageMaskargument is instead set toVK_PIPELINE_STAGE_ACCELERATION_STRUCTURE_BUILD_BIT_KHR.To summarize:
Argument
srcStageMaskinvkCmdPipelineBarrieris incorrectly set toVK_PIPELINE_STAGE_ACCELERATION_STRUCTURE_BUILD_BIT_KHR, when it should be set toVK_PIPELINE_STAGE_TRANSFER_BITin order to guarantee synchronization of
vkCmdCopyBuffer.