Fix the Context::getCompatibleDevices() method, to skip the CPU devic… #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e type for calling getDeviceExtensions() Signed-off-by: Frederique Hsu <frederique.hsu@outlook.com>
Frederique-Hsu
force-pushed
the
fix/getCompatibleDevices
branch
from
6f60731 to
fa3b64f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue had been described in #85
Root cause:
Since the getDeviceExtensions() will return all extensions, when passing an argument of CPU device.
Hence we have to skip the CPU-type device.
Especially, when user wants to enable the "VK_KHR_ray_tracing_pipeline" extension, it will return a wrong compatible device to user, provided that not skip the CPU type.
Fix solution:
add a checking for the
props.deviceType, skip the CPU type.