encoder: flush async pipeline in GetBitstream before shutdown#220
Merged
encoder: flush async pipeline in GetBitstream before shutdown#220
Conversation
GetBitstream() was a no-op stub that never flushed the async assembly pipeline. The test app calls GetBitstream() after encoding all frames, expecting it to complete all pending assembly work. Without the flush, deferred frames with unsignaled fences remain in the assembly queue. Fix: GetBitstream() now calls WaitForThreadsToComplete() which pushes deferred frames, waits for assembly threads to finish, and joins them. Also adds VkThreadSafeQueue::Drain() utility and m_vkDevCtx null guard in DeinitEncoder() for robustness during partial-init teardown. Signed-off-by: Tony Zlatinski <tzlatinski@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetBitstream() was a no-op stub that never flushed the async assembly pipeline. The test app calls GetBitstream() after encoding all frames, expecting it to complete all pending assembly work. Without the flush, deferred frames with unsignaled fences remain in the assembly queue.
Fix: GetBitstream() now calls WaitForThreadsToComplete() which pushes deferred frames, waits for assembly threads to finish, and joins them.
Also adds VkThreadSafeQueue::Drain() utility and m_vkDevCtx null guard in DeinitEncoder() for robustness during partial-init teardown.