Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ yarn test {plugin}
To run e2e tests for a plugin, run:

```
yarn e2e {plugin}
yarn e2e {plugin}-e2e
```

## Testing Locally
Expand Down
8 changes: 7 additions & 1 deletion packages/ionic-angular/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
# Changelog

# 13.1.1

## Bug Fixes

- move `@nrwl/angular` to dependencies section of `package.json`

# 13.1.0

# Features
## Features

- add page generator (courtesy of @joshuamorony)

Expand Down
2 changes: 1 addition & 1 deletion packages/ionic-angular/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nxtend/ionic-angular",
"version": "13.1.0",
"version": "13.1.1",
"description": "An Nx plugin for developing Ionic React applications and libraries",
"author": {
"name": "Devin Shoemaker",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ describe('application schematic', () => {

const packageJson = readJson(appTree, 'package.json');
expect(packageJson.dependencies['@ionic/angular']).toBeDefined();
expect(packageJson.devDependencies['@nrwl/angular']).toBeDefined();
expect(packageJson.dependencies['@nrwl/angular']).toBeDefined();
expect(packageJson.devDependencies['@nxtend/capacitor']).toBeDefined();
});

Expand Down
Original file line number Diff line number Diff line change
@@ -1,16 +1,26 @@
import { addDependenciesToPackageJson, Tree } from '@nrwl/devkit';
import { addDependenciesToPackageJson, readJson, Tree } from '@nrwl/devkit';
import {
ionicAngularVersion,
nxtendCapacitorVersion,
nxVersion,
} from '../../../utils/versions';

let packageJson;

const isExistingDependency = (name: string) =>
packageJson?.dependencies?.[name] ? true : false;

export function addDependencies(host: Tree) {
return addDependenciesToPackageJson(
host,
{
'@ionic/angular': ionicAngularVersion,
},
{ '@nrwl/angular': nxVersion, '@nxtend/capacitor': nxtendCapacitorVersion }
);
packageJson = readJson(host, 'package.json');
let dependencies: Record<string, string> = {
'@ionic/angular': ionicAngularVersion,
};

if (!isExistingDependency('@nrwl/angular')) {
dependencies = { ...dependencies, '@nrwl/angular': nxVersion };
}

return addDependenciesToPackageJson(host, dependencies, {
'@nxtend/capacitor': nxtendCapacitorVersion,
});
}