Fixed crossfade not working when Snowify is minimized#34
Open
KerbalMissile wants to merge 1 commit intonyakuoff:mainfrom
Open
Fixed crossfade not working when Snowify is minimized#34KerbalMissile wants to merge 1 commit intonyakuoff:mainfrom
KerbalMissile wants to merge 1 commit intonyakuoff:mainfrom
Conversation
Owner
|
hi, @ssantss can you check this, since you made the whole crossfade feature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically when Snowify is minimized crossfade doesn't work and it keeps "playing" the song but just doesn't play audio and keeps running it, so when you open it back up, it may be halfway through without you hearing anything. I fixed this by adding just two lines of code preventing throttling and deprioritizing of the renderer process when the app is minimized. I tested it without and with the fix I applied on the latest source code and it does indeed fix the issue properly.