Outgoing phases, default responses#2
Open
thedavidmccann wants to merge 15 commits intonyaruka:masterfrom
thedavidmccann:master
Open
Outgoing phases, default responses#2thedavidmccann wants to merge 15 commits intonyaruka:masterfrom thedavidmccann:master
thedavidmccann wants to merge 15 commits intonyaruka:masterfrom
thedavidmccann:master
Conversation
Collaborator
Author
|
Okay, awesome mass texting functionality incorporated and tested. Feel free to, yknow, merge it! :-D |
Collaborator
There was a problem hiding this comment.
So I'm missing how the above functionality has been replaced. How does a multi worker gunicorn config work now without dupe messages?
…action because it's a POST, 'action ' param isn't there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yeah, default response should never have gone in here. There's actually something useful in rapidsms.contrib after all...
However, I needed to re-institute outgoing phases, to hijack outgoing messages to blacklisted numbers. Cool?
Also added handled_by field which contains the name of the first app from SMS_APPS to return true when its handle() method is called.