-
-
Couldn't load subscription status.
- Fork 444
remove "web" from reddit share url #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
remove "web" from reddit share url #572
Conversation
🦋 Changeset detectedLatest commit: 99146ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Thank you for the contribution.
Not the that /web was included in the path recently in this PR.
Unfortunately, I don't have the time to investigate what is the correct url after all. It might depend on the case. Nevertheless, it would be good that we don't end up going back-and-forth with the url in different releases.
Any chance you could test the case "Verified that the link is now correctly populated in Reddit share previews (#547 )" and think of a solution that would in all cases?
|
Any plans to merge this? The current share button implementation is completely broken for me |
|
Just a friendly note to urge you to please merge this PR :-) |
Remove "web" element from path for RedditShareButton
Current issue:
Fix: