fix: Missing webhook URL validation#26
Open
mrwind-up-bird wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Missing webhook URL validation
Category: security
Severity: low
Issue
Webhook URLs are not validated for scheme, domain, or port restrictions. This could allow SSRF attacks where attackers register webhooks pointing to internal services or localhost endpoints to probe internal infrastructure.
Fix
Added URL validation function to prevent SSRF attacks by restricting webhook URLs to http/https schemes only and blocking private, loopback, and link-local IP addresses. The validation is applied to both the main Webhook model and WebhookCreate schema to ensure all webhook URLs are validated at creation time.
Generated by nyxCore AutoFix