fix: Potential infinite loop in recursive splitting#29
Open
mrwind-up-bird wants to merge 1 commit intomainfrom
Open
fix: Potential infinite loop in recursive splitting#29mrwind-up-bird wants to merge 1 commit intomainfrom
mrwind-up-bird wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Potential infinite loop in recursive splitting
Category: bug
Severity: low
Issue
The _recursive_split function could theoretically enter infinite recursion if a separator produces parts that are still too large and no character-level fallback is reached, though this is unlikely with the current separator list.
Fix
Added a recursion depth limit parameter to prevent infinite loops. If recursion depth exceeds 50 levels, the function falls back to character-level splitting to guarantee termination. This maintains existing functionality while preventing the theoretical infinite recursion scenario.
Generated by nyxCore AutoFix