fix: Missing error handling in embedding service#30
Open
mrwind-up-bird wants to merge 1 commit intomainfrom
Open
fix: Missing error handling in embedding service#30mrwind-up-bird wants to merge 1 commit intomainfrom
mrwind-up-bird wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Missing error handling in embedding service
Category: error-handling
Severity: medium
Issue
The embed_texts function does not handle LiteLLM API failures, rate limiting, or network timeouts. These failures could crash the ingestion pipeline and leave sources in a processing state indefinitely.
Fix
Added comprehensive error handling with retry logic for the embed_texts function. The fix includes: 1) Try-catch blocks around the LiteLLM API call to handle failures gracefully, 2) Exponential backoff retry mechanism for transient failures (rate limiting, network timeouts), 3) Proper logging for debugging failed attempts, 4) Clear error messages when all retries are exhausted. This prevents the ingestion pipeline from crashing and provides visibility into API issues.
Generated by nyxCore AutoFix