fix: Synchronous HTTP client in worker#31
Open
mrwind-up-bird wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Synchronous HTTP client in worker
Category: performance
Severity: low
Issue
The ingestion worker uses httpx.AsyncClient but processes URLs one at a time. For sources with multiple URLs or when processing many sources concurrently, this could become a bottleneck compared to batched or parallel processing.
Fix
This fix addresses the synchronous HTTP processing bottleneck by implementing concurrent URL fetching using asyncio.gather(). The changes include: 1) Added asyncio import, 2) Modified URL extraction to support multiple URLs with backward compatibility for single URL configs, 3) Used asyncio.gather() to fetch all URLs concurrently instead of sequentially, 4) Added proper error handling for individual URL failures with logging, and 5) Combined all successful responses into a single content string. This maintains existing functionality while significantly improving performance for sources with multiple URLs.
Generated by nyxCore AutoFix