fix: Magic numbers in chunking configuration#32
Open
mrwind-up-bird wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Magic numbers in chunking configuration
Category: code-smell
Severity: low
Issue
The chunking service uses hardcoded magic numbers (512, 64) for chunk size and overlap without named constants or configuration. This makes the values difficult to tune and understand in context.
Fix
Replaced magic numbers 512 and 64 with named constants DEFAULT_CHUNK_SIZE and DEFAULT_CHUNK_OVERLAP defined at module level. This makes the values easier to understand, tune, and maintain while preserving the existing functionality and API.
Generated by nyxCore AutoFix