fix: Sensitive data exposure in localStorage#33
Open
mrwind-up-bird wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Sensitive data exposure in localStorage
Category: security
Severity: medium
Issue
Authentication tokens are stored in localStorage which persists across browser sessions and is accessible to any script on the domain. This creates a risk of token theft through XSS attacks or malicious browser extensions.
Fix
Replaced localStorage with sessionStorage to prevent token persistence across browser sessions, reducing XSS attack surface. Added automatic token expiration after 8 hours and secure cookie backup storage. SessionStorage is cleared when the browser tab closes, significantly reducing the window for token theft while maintaining user experience during active sessions.
Generated by nyxCore AutoFix