fix: Inefficient DOM manipulation in widget streaming#37
Open
mrwind-up-bird wants to merge 1 commit intomainfrom
Open
fix: Inefficient DOM manipulation in widget streaming#37mrwind-up-bird wants to merge 1 commit intomainfrom
mrwind-up-bird wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Inefficient DOM manipulation in widget streaming
Category: performance
Severity: medium
Issue
The _updateStreamingMessage function searches through all message bubbles to find the last one for each streaming update. This creates O(n) complexity for each character streamed, causing performance degradation with long conversations.
Fix
The fix caches a reference to the last message element in
_lastMessageElementinstead of searching through all DOM elements on each streaming update. This eliminates the O(n) complexity by providing direct O(1) access to the element that needs updating. The cache is properly managed by clearing it during full re-renders and when showing typing indicators.Generated by nyxCore AutoFix