fix: Silent JSON parsing failures in SSE stream#38
Open
mrwind-up-bird wants to merge 1 commit intomainfrom
Open
fix: Silent JSON parsing failures in SSE stream#38mrwind-up-bird wants to merge 1 commit intomainfrom
mrwind-up-bird wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Silent JSON parsing failures in SSE stream
Category: error-handling
Severity: medium
Issue
The SSE stream processing catches JSON parsing errors but silently ignores them with an empty catch block. This could hide legitimate parsing issues and make debugging stream problems difficult.
Fix
Replaced the silent catch block with proper error logging that captures the parse error and the malformed data string. This maintains the existing behavior of continuing stream processing while providing visibility into JSON parsing issues for debugging purposes.
Generated by nyxCore AutoFix