Skip to content

fix: Missing error boundary for widget failures #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrwind-up-bird wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Missing error boundary for widget failures #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 53 additions & 6 deletions dashboard/widget/minirag-widget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,25 +35,56 @@
}

connectedCallback() {
// Allow attribute overrides on the custom element itself
const botId = this.getAttribute('bot-id') || config.botId;
const apiUrl = this.getAttribute('api-url') || config.apiUrl;
const apiToken = this.getAttribute('api-token') || config.apiToken;
const title = this.getAttribute('title') || config.title;
try {
// Allow attribute overrides on the custom element itself
const botId = this.getAttribute('bot-id') || config.botId;
const apiUrl = this.getAttribute('api-url') || config.apiUrl;
const apiToken = this.getAttribute('api-token') || config.apiToken;
const title = this.getAttribute('title') || config.title;

this._config = { botId, apiUrl, apiToken, title };
} catch (error) {
console.error('MiniRAG Widget initialization error:', error);
this._renderError('Failed to initialize widget');
return;
}

this._config = { botId, apiUrl, apiToken, title };
this._loadStyles();
}

_loadStyles() {
try {
const link = document.createElement('link');
link.rel = 'stylesheet';
link.href = cssUrl;
this.shadowRoot.appendChild(link);
} catch (error) {
console.error('MiniRAG Widget CSS loading error:', error);
this._renderError('Failed to load widget styles');
return;
}


this._container = document.createElement('div');
this.shadowRoot.appendChild(this._container);
this._render();
}

_render() {
try {
this._renderContent();
} catch (error) {
console.error('MiniRAG Widget render error:', error);
this._renderError('Widget failed to render');
}
}

_renderContent() {
const c = this._container;
if (!c) {
throw new Error('Container not found');
}

const c = this._container;
c.innerHTML = '';

Expand Down Expand Up @@ -172,6 +203,22 @@
</svg>`;
bubble2.onclick = () => { this._open = false; this._render(); };

_renderError(message) {
if (!this._container) {
this.shadowRoot.innerHTML = `<div style="color: red; padding: 10px; font-family: sans-serif;">${message}</div>`;
return;
}

this._container.innerHTML = `
<div style="
background: #fee; border: 1px solid #fcc; border-radius: 4px;
padding: 12px; margin: 8px; color: #c33; font-family: sans-serif;
font-size: 14px; text-align: center;
">
⚠️ ${this._escHtml(message)}
</div>`;
}

c.appendChild(win);
c.appendChild(bubble2);

Expand Down