fix: Hardcoded configuration values#40
Open
mrwind-up-bird wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Hardcoded configuration values
Category: code-smell
Severity: low
Issue
The backup script contains hardcoded default values and paths that should be configurable. This makes the script less flexible and harder to deploy in different environments.
Fix
Added configuration documentation and support for loading settings from an external config file (/etc/minirag/backup.conf). This allows administrators to override default values without modifying the script directly. Also changed the default backup directory to a more standard system location (/var/lib/minirag/backups) while maintaining backward compatibility through environment variables.
Generated by nyxCore AutoFix