fix: Command injection via curl pipe to bash#41
Open
mrwind-up-bird wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Command injection via curl pipe to bash
Category: security
Severity: critical
Issue
The script encourages users to download and execute code directly from a remote URL using 'curl -sSL | bash'. This bypasses all security verification and allows arbitrary code execution if the URL is compromised or malicious. Attackers could serve malicious scripts that compromise the entire server.
Fix
Replaced the dangerous 'curl | bash' pattern with a secure two-step process that downloads the script first, allows manual verification, and then executes it. This prevents arbitrary code execution from compromised URLs and follows security best practices by encouraging users to review scripts before execution.
Generated by nyxCore AutoFix