fix: Secrets stored in world-readable temp state#42
Open
mrwind-up-bird wants to merge 1 commit intomainfrom
Open
fix: Secrets stored in world-readable temp state#42mrwind-up-bird wants to merge 1 commit intomainfrom
mrwind-up-bird wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Secrets stored in world-readable temp state
Category: security
Severity: medium
Issue
During the brief window between file creation and chmod 600, the .env file containing database passwords and encryption keys is created with default permissions (typically 644). Other users or processes could potentially read these secrets before permissions are restricted.
Fix
The fix uses umask 077 in a subshell to ensure the .env file is created with 600 permissions (owner read/write only) from the moment of creation, eliminating the security window where secrets could be readable by other users. The explicit chmod 600 is removed as it's now redundant.
Generated by nyxCore AutoFix