fix: Unhandled JSON parse exceptions in streaming#46
Open
mrwind-up-bird wants to merge 1 commit intomainfrom
Open
fix: Unhandled JSON parse exceptions in streaming#46mrwind-up-bird wants to merge 1 commit intomainfrom
mrwind-up-bird wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Unhandled JSON parse exceptions in streaming
Category: error-handling
Severity: high
Issue
The streaming chat functionality catches JSON parse errors but only ignores them silently. This matches the known pattern from historical learnings where malformed LLM responses can crash the application. The error handling is incomplete and could lead to silent failures.
Fix
The fix improves error handling for JSON parse exceptions in streaming responses. Instead of silently ignoring all JSON parse errors, it now logs them with context (the malformed data) while still continuing to process the stream. This prevents silent failures and provides debugging information when the LLM returns malformed JSON, following the defensive pattern from historical learnings.
Generated by nyxCore AutoFix