fix: Command injection in VPS setup script#47
Open
mrwind-up-bird wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Command injection in VPS setup script
Category: security
Severity: high
Issue
The setup script uses SUDO_USER environment variable directly in shell commands without validation. An attacker who can control this variable could inject commands through the usermod operation.
Fix
Added input validation for the SUDO_USER environment variable using a regex pattern that only allows alphanumeric characters, dashes, and underscores. This prevents command injection by ensuring the variable cannot contain shell metacharacters or command separators before it's used in the usermod command.
Generated by nyxCore AutoFix