fix: Unbounded batch processing in embedding#49
Open
mrwind-up-bird wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Unbounded batch processing in embedding
Category: performance
Severity: medium
Issue
The embedding service processes texts in batches of 128, but there's no upper limit on the total number of texts. For very large documents, this could lead to memory exhaustion or extremely long processing times without progress feedback.
Fix
Added a maximum limit (MAX_TOTAL_TEXTS = 10000) on the total number of texts that can be processed in a single embedding request. This prevents memory exhaustion and extremely long processing times by failing fast with a clear error message when the limit is exceeded. The limit is set high enough to handle legitimate large documents while preventing abuse or accidental resource exhaustion.
Generated by nyxCore AutoFix