Fix building with GCC 10 / CFLAGS=-fno-common

[jer-gentoo]

No description provided.

[nyxdis]

Hi! Thanks for these changes. Unfortunately it seems you've forgot to add the extern keyword to the buffer variable in audioscrobbler.h (I guess?). The current version does not compile with gcc10 here.
If you could fix that and test it (I cannot test it currently), I'd be glad to merge your pull request.

[jer-gentoo]

I'm not sure why that would fail with gcc10 for you but not for me. The declaration of struct as_conn_t in src/audioscrobbler.h is used exclusively in src/audioscrobbler.c, where its definition as as_conn is declared static for that reason.

[nyxdis]

It doesn't fail because of as_conn, it fails because of buffer that's declared both in audioscrobbler.c and audioscrobbler.h.

[jer-gentoo]

Oh I see. The changes committed here differ from those in the patch I applied here at [0]. Not sure how some of those changes were lost.

[0] https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c9f42ac8feb314f3f2f6ec7cfd8c535ff33fe735