RVL: Add an overscan option for screen width#49
Draft
sbeeds wants to merge 1 commit intonzp-team:mainfrom
Draft
Conversation
MotoLegacy
reviewed
Feb 13, 2025
| // ELUTODO: really necessary? | ||
| //GX_InvVtxCache(); | ||
| //GX_InvalidateTexAll(); | ||
| GX_SetScissor(*x,*y,*width > 640 ? 640 - (vid_overscan_width.value * 360) : *width - (vid_overscan_width.value * 360),*height); |
Member
There was a problem hiding this comment.
Can you explain what we're doing here? Is this adding a border/shrinking our render resolution?
Collaborator
Author
There was a problem hiding this comment.
It adjusts the view scissor based on vid_overscan_width value. When this value is increased, the start value (normally 0) of the width of the scissor gets shifted over, and the right side pixels get culled. This will never cull more than 36 pixels from the right side. I will upload a fix later to adjust the 2d resolution, which will offset the HUD accordingly.
Member
There was a problem hiding this comment.
It sounds like this is incomplete then. Please mark this as a draft
Contributor
|
With this we should probably set viWidth to 720 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds a new settings option to adjust the picture width in order to accommodate tv or monitor used
Visual Sample
Checklist