Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds Android support to the bclibc_ffi package by updating the library loading logic in Dart and providing a new CMake configuration for the build process. Review feedback suggests using the lib() helper function for Android to maintain consistency with other platforms and recommends removing or conditionalizing debug messages in the CMakeLists.txt file to keep the build output clean.
| } | ||
|
|
||
| if (Platform.isLinux) return ffi.DynamicLibrary.open(lib('libbclibc_ffi.so')); | ||
| if (Platform.isAndroid) return ffi.DynamicLibrary.open('libbclibc_ffi.so'); |
There was a problem hiding this comment.
For consistency with other platforms and to leverage the lib() helper function's logic (e.g., for development paths), consider using lib('libbclibc_ffi.so') instead of directly opening the library name.
| if (Platform.isAndroid) return ffi.DynamicLibrary.open('libbclibc_ffi.so'); | |
| if (Platform.isAndroid) return ffi.DynamicLibrary.open(lib('libbclibc_ffi.so')); |
| message(STATUS "[bclibc_ffi/android] Project root: ${PROJECT_ROOT}") | ||
| message(STATUS "[bclibc_ffi/android] bclibc path: ${BCLIBC_ROOT}") |
There was a problem hiding this comment.
These message(STATUS) calls are useful for debugging but can clutter the build output for consumers of this library. Consider removing them or making them conditional (e.g., only in debug builds or if a specific CMake variable is set) once the Android build is stable.
Linux AppImage Build✅ Build successful!
📦 Download AppImage PR: #19 · Commit: Test Instructions:# Download and run
chmod +x ebalistyka-x86_64.AppImage
./ebalistyka-x86_64.AppImage |
Windows EXE Build✅ Build successful!
PR: #19 · Commit: Test Instructions:# Download and extract
Expand-Archive ebalistyka-windows-x86_64-release-0.1.2-dev-211.zip
cd ebalistyka-windows-x86_64-release-0.1.2-dev-211
# Check if bclibc_ffi.dll exists
ls *.dll | findstr bclibc
# Run the app
.\ebalistyka.exe |
Android APK Build✅ Build successful! PR: #19 · Commit: Test Instructions:# arm64 (most modern phones)
adb install ebalistyka_android_arm64.apk
# arm32 (older phones)
adb install ebalistyka_android_armeabi_v7a.apk |
o-murphy
force-pushed
the
build/android
branch
3 times, most recently
from
820f09e to
2a9e1ba
Compare
Android Build✅ Build successful! PR: #19 · Commit: |
o-murphy
changed the title
1 participant
No description provided.