Skip to content

Updated replayer address and first block slot #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 25, 2025
Merged

Updated replayer address and first block slot #1631

merged 3 commits into from
Nov 25, 2025
+28 −7

Conversation

@0xMimir
Copy link
Contributor

@0xMimir 0xMimir commented Nov 12, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 12, 2025 •
edited
Loading

OCaml Reference Validation Results

Repository: https://github.com/MinaProtocol/mina.git
Branch: compatible
Status: ✓ Validation passed

Click to see full validation output 
Checking OCaml references against https://github.com/MinaProtocol/mina.git (branch: compatible)
Fetching current commit from compatible...
Current OCaml commit: a58aa5141f9b62f9276a22e605ecd6363d81960a

Validating references...
========================
✓ VALID: ledger/src/account/account.rs -> src/lib/mina_base/account.ml L:201-224
  ⚠ STALE COMMIT: fc6be4c58091c761f827c858229c2edf9519e941 (current: a58aa5141f9b62f9276a22e605ecd6363d81960a)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2285-2285
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a58aa5141f9b62f9276a22e605ecd6363d81960a)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2351-2356
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a58aa5141f9b62f9276a22e605ecd6363d81960a)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2407
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a58aa5141f9b62f9276a22e605ecd6363d81960a)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:9-51
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a58aa5141f9b62f9276a22e605ecd6363d81960a)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:452-454
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a58aa5141f9b62f9276a22e605ecd6363d81960a)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/with_status.ml L:6-10
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a58aa5141f9b62f9276a22e605ecd6363d81960a)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:76-80
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a58aa5141f9b62f9276a22e605ecd6363d81960a)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:68-69
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a58aa5141f9b62f9276a22e605ecd6363d81960a)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/coinbase.ml L:17-21
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a58aa5141f9b62f9276a22e605ecd6363d81960a)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/transaction/transaction.ml L:8-11
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a58aa5141f9b62f9276a22e605ecd6363d81960a)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:34-48
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a58aa5141f9b62f9276a22e605ecd6363d81960a)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/stake_delegation.ml L:11-13
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a58aa5141f9b62f9276a22e605ecd6363d81960a)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:179-181
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a58aa5141f9b62f9276a22e605ecd6363d81960a)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:239-243
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a58aa5141f9b62f9276a22e605ecd6363d81960a)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:352-362
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a58aa5141f9b62f9276a22e605ecd6363d81960a)

Summary
=======
Total references found: 16
Valid references: 16
Invalid references: 0
Stale commits: 16

⚠ Warning: 16 reference(s) have stale commits
Run with --update to update them automatically

@github-actions
Copy link

github-actions bot commented Nov 12, 2025 •
edited
Loading

✓ Code Reference Verification Passed

All code references in the documentation have been verified successfully!

Total references checked: 1
Valid references: 1

The documentation is in sync with the codebase on the develop branch.

@0xMimir 0xMimir force-pushed the bugfix/solo-node-bootstrap branch 2 times, most recently from 03c5926 to f740ad5 Compare November 12, 2025 14:51
@dannywillems
Copy link
Member

dannywillems commented Nov 12, 2025

Can you give the commands you use to test it locally?

@0xMimir 0xMimir force-pushed the bugfix/solo-node-bootstrap branch from f740ad5 to 6adbe01 Compare November 12, 2025 15:57
dannywillems
dannywillems reviewed Nov 12, 2025
View reviewed changes
@0xMimir 0xMimir force-pushed the bugfix/solo-node-bootstrap branch from 9fcf264 to 4265287 Compare November 12, 2025 16:28
@dannywillems dannywillems force-pushed the bugfix/solo-node-bootstrap branch from 4265287 to 866e111 Compare November 12, 2025 17:22
@dannywillems dannywillems moved this to In Progress in Rust node Nov 12, 2025
@0xMimir 0xMimir force-pushed the bugfix/solo-node-bootstrap branch from 866e111 to c56418c Compare November 12, 2025 17:30
dannywillems
dannywillems reviewed Nov 12, 2025
View reviewed changes
dannywillems
dannywillems reviewed Nov 12, 2025
View reviewed changes
@0xMimir 0xMimir force-pushed the bugfix/solo-node-bootstrap branch from c56418c to df7895e Compare November 12, 2025 17:43
dannywillems
dannywillems reviewed Nov 12, 2025
View reviewed changes
dannywillems
dannywillems reviewed Nov 12, 2025
View reviewed changes
dannywillems
dannywillems reviewed Nov 12, 2025
View reviewed changes
dannywillems
dannywillems reviewed Nov 12, 2025
View reviewed changes
dannywillems
dannywillems reviewed Nov 12, 2025
View reviewed changes
@dannywillems
Copy link
Member

dannywillems commented Nov 12, 2025

Can you also rebase on top of develop, please?

@0xMimir 0xMimir force-pushed the bugfix/solo-node-bootstrap branch 7 times, most recently from 4ae5ca3 to 960460e Compare November 17, 2025 16:03
@0xMimir 0xMimir force-pushed the bugfix/solo-node-bootstrap branch 2 times, most recently from 771a348 to 3663c77 Compare November 17, 2025 19:12
@0xMimir 0xMimir requested a review from dannywillems November 18, 2025 14:04
richardpringle
richardpringle reviewed Nov 19, 2025
View reviewed changes
Copy link
Contributor

@richardpringle richardpringle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think the Cargo.lock changes shouldn't be here. Seems like they should be in the code though, I would just split that out into a new PR

@0xMimir 0xMimir force-pushed the bugfix/solo-node-bootstrap branch from 3663c77 to fa5f8ca Compare November 19, 2025 14:40
dannywillems
dannywillems previously approved these changes Nov 19, 2025
View reviewed changes
@dannywillems dannywillems force-pushed the bugfix/solo-node-bootstrap branch from fa5f8ca to 2d18b92 Compare November 19, 2025 16:16
@0xMimir 0xMimir force-pushed the bugfix/solo-node-bootstrap branch 2 times, most recently from de7dca1 to 0ccf463 Compare November 20, 2025 08:28
dannywillems
dannywillems reviewed Nov 20, 2025
View reviewed changes
Copy link
Member

@dannywillems dannywillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the file.

@0xMimir 0xMimir force-pushed the bugfix/solo-node-bootstrap branch from 0ccf463 to c2e90fa Compare November 21, 2025 07:53
@0xMimir 0xMimir force-pushed the bugfix/solo-node-bootstrap branch 3 times, most recently from 5f6c043 to a757dcc Compare November 24, 2025 19:57
0xMimir and others added 2 commits November 24, 2025 22:00
@dannywillems dannywillems force-pushed the bugfix/solo-node-bootstrap branch from a757dcc to e1b12a2 Compare November 25, 2025 01:00
@0xMimir 0xMimir force-pushed the bugfix/solo-node-bootstrap branch 2 times, most recently from 015c690 to a8f3389 Compare November 25, 2025 08:19
@0xMimir @dannywillems
Update node/testing/tests/single_node.rs
937ba61 
Co-authored-by: Danny Willems <be.danny.willems@gmail.com>
@0xMimir 0xMimir force-pushed the bugfix/solo-node-bootstrap branch from a8f3389 to 937ba61 Compare November 25, 2025 11:43
@richardpringle richardpringle merged commit a7369e3 into develop Nov 25, 2025
107 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardpringle richardpringle richardpringle approved these changes

@dannywillems dannywillems Awaiting requested review from dannywillems

Assignees

@0xMimir 0xMimir

Labels

no changelog

Projects

Rust node
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@0xMimir @dannywillems @richardpringle